Update to "Text" Content Block Breaks Caption Editing

leftquark

From this thread (http://www.dgrin.com/showpost.php?p=1922405&postcount=11):

bwg wrote: »

Just pushed an update to the text editor. Added support for headings and fixed all the formatting wonkiness. Let us know if you run into any problems.

And yet you broke the Caption editor. I can't enter all the HTML I used to be able to. I noticed this yesterday. I had some <h4> tag's in my caption. I went to add to the caption and the <h4>'s disappeared. Now I can't add them back. Any time I add them they get removed.
Example: http://www.aaronmphotography.com/Customizations2/i-c5fQ3Tk (the text "For Gallery and Folder Images Only" should be in an <H4>)

If I go to captions that already have it, and go to edit my caption, I noticed that the closing </h4> is not displayed, but the opening <h4> is. If I click cancel my heading 4's are still there and load as headings on the page. If I click save, they go away.
Here's an example of them working: http://www.aaronmphotography.com/Customizations2/i-Zx6GJjS

I checked with <h3>'s as well. No dice.

Please fix and send a note to QA to tell them they missed this in their testing!

bwg

leftquark wrote: »

From this thread (http://www.dgrin.com/showpost.php?p=1922405&postcount=11):


And yet you broke the Caption editor. I can't enter all the HTML I used to be able to. I noticed this yesterday. I had some <h4> tag's in my caption. I went to add to the caption and the <h4>'s disappeared. Now I can't add them back. Any time I add them they get removed.
Example: http://www.aaronmphotography.com/Customizations2/i-c5fQ3Tk (the text "For Gallery and Folder Images Only" should be in an <H4>)

If I go to captions that already have it, and go to edit my caption, I noticed that the closing </h4> is not displayed, but the opening <h4> is. If I click cancel my heading 4's are still there and load as headings on the page. If I click save, they go away.
Here's an example of them working: http://www.aaronmphotography.com/Customizations2/i-Zx6GJjS

I checked with <h3>'s as well. No dice.

Please fix and send a note to QA to tell them they missed this in their testing!

I'll reiterate, the update to the text editor did not do anything to the image captions. Completely unrelated.

Image captions have been HTML whitelisted for weeks now. Heading tags are not in the HTML whitelist, which is why they are being stripped.

As I said in my earlier response, we will look into why they aren't currently included in the whitelist.

Allen

What's a "HTML whitelist" and what's in it?

beardedgit

Allen wrote: »

What's a "HTML whitelist" and what's in it?

If it's anything like the white box in the Tools > Organize > Replace screen bug, there could be the entire works of Shakespeare in it and you'd still think it was empty DD

bwg

bwg wrote: »

I'll reiterate, the update to the text editor did not do anything to the image captions. Completely unrelated.

Image captions have been HTML whitelisted for weeks now. Heading tags are not in the HTML whitelist, which is why they are being stripped.

As I said in my earlier response, we will look into why they aren't currently included in the whitelist.

heading tags are no longer stripped from image captions.

leftquark

bwg wrote: »

heading tags are no longer stripped from image captions.

Wahoo. Thanks!

Perhaps I'm taking this the wrong way ... but I detected a hint of annoyance and frustration in your original response above ... somewhat of a rude tone to give as a support hero response. As someone who has helped a lot of people on here I frequently pull my hair out and say to myself "SERIOUSLY? I really want to write the rudest reply back" but usually am able to check myself. I understand how sometimes the things people write can be frustrating but as a rep for SM you have to always show the utmost respect, even if someone is being stupid.

With that said, I also acknowledge that my original post also carried a rude tone and apologize for that.