Changed menu pinning?

RichardRichard Mildly bemusedMadrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator
edited April 25, 2018 in Bug Reporting

Has anyone else noticed a change in pinned menu behavior today? When I am logged on as owner, my menu is pinned but there is a space between it and the top of the browser window. It used to pin at the very top, which is what I want.

At login:

After scrolling:

Fortunately this is only happening in the owner view; in the visitor view it is still correctly pinned at the top. I'm guessing that some change in the SM header is responsible, but I'm not sure how to fix it without breaking the visitor view.

Suggestions?

Comments

  • denisegoldbergdenisegoldberg Major grins North Andover, MAPosts: 11,922Super Moderators moderator

    I see it on my site in both owner view and visitor view. I think it started a couple of days ago.

    I think the previous behavior is the preferred behavior - it looks sloppy now.

    I'd love a fix, preferably a change back by smug, but CSS would be OK.

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    I hate the way it looks.

  • MarcQuinlivanMarcQuinlivan Beginner grinner IrelandPosts: 29Registered Users Big grins

    Yes, I have it too an all four of my sites.

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    @MarcQuinlivan said:
    Yes, I have it too an all four of my sites.

    I looked at your site and the visitor view doesn't seem to have the problem. So are you seeing it only in the owner view (like me)? Denise's visitor view does have the problem.

  • MarcQuinlivanMarcQuinlivan Beginner grinner IrelandPosts: 29Registered Users Big grins

    @Richard said:

    @MarcQuinlivan said:
    Yes, I have it too an all four of my sites.

    I looked at your site and the visitor view doesn't seem to have the problem. So are you seeing it only in the owner view (like me)? Denise's visitor view does have the problem.

    Sorry, just logged in view for me. I misread Denise's comment.

  • MarcQuinlivanMarcQuinlivan Beginner grinner IrelandPosts: 29Registered Users Big grins

    I've looked into the code on my homepage - www.marcquinlivan.photography.

    The menu bar when viewing the top of the page is showing as:
    <div class="sm-page-layout-region sm-page-layout-region-header" style="width: inherit; min-height: 0px;">

    Then if I scroll down just enough for the menu bar to go off the screen it reappears and the code changes to:

    <div class="sm-page-layout-region sm-page-layout-region-header sm-page-layout-region-pinned" style="width: 2094px; min-height: 0px;">

    It appears to be a change to how Pinning works when logged in that is causing it.

    If you go to Customize\Content & Design\ Entire Site\Layout\Pinning" and select "None" the problem should go away.

    I have my sites set to pin the header.

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    @MarcQuinlivan said:
    If you go to Customize\Content & Design\ Entire Site\Layout\Pinning" and select "None" the problem should go away.

    But I want the menu pinned. Setting it to none just causes the menu to scroll off the top.

  • MarcQuinlivanMarcQuinlivan Beginner grinner IrelandPosts: 29Registered Users Big grins

    @Richard said:

    @MarcQuinlivan said:
    If you go to Customize\Content & Design\ Entire Site\Layout\Pinning" and select "None" the problem should go away.

    But I want the menu pinned. Setting it to none just causes the menu to scroll off the top.

    Yes, I know. I want the same thing.

    I was just pointing out what it was that is causing the issue and demonstrating it.

  • denisegoldbergdenisegoldberg Major grins North Andover, MAPosts: 11,922Super Moderators moderator

    I wish I knew what is causing my site to misbehave both when logged in and logged out.

    My header includes 2 elements with slightly different spacing from the top. But even when I change the spacing to match I still see odd behavior.

  • Lille UlvenLille Ulven Lille Ulven ScandinaviaPosts: 495Registered Users Major grins

    I think I know what is causing it - but I don't know how to fix it.
    SmugMug uses a data-pinned-region="Header" div-attribute which causes the menu to be pinned.
    The menu line is defined in a <div class="sm-page-layout-region sm-page-layout-region-header" style="width: inherit; min-height: 0px;">
    But the white area above your menu is defined earlier in another div: <div id="sm-page-header"><!-- react-empty: 1 --></div>
    It is the later div that is not reacting on the data-pinned-region="Header".

    I suppose someone from SmugMug needs to have a look at the code that is evaluating the data-pinned-region attribute. I don't think – at least I haven't found it yet – there is a way to fix this by CSS.
    @leftquark could you inform one of the developers of this misbehavior? data-pinned-region="Left" seems to work fine though.

    http://www.lilleulven.com - The Photos of my travels
    http://blog.lilleulven.com - The Stories of my travels
  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator
    edited April 25, 2018

    Thanks Lille. I had reported this problem to the SM help desk before creating this thread. As of yesterday, it sounds like they have classified this as a bug and have referred it to engineering for investigation. Hopefully your findings will point them in the right direction. :+1:

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    Working with SmugHero Tom this morning, we found that the client view of my site also has the wonky behavior in Chrome on OS-X and Win10, but it behaves correctly on my Win7 machine.

    Curiouser and curiouser...

  • tomnovytomnovy SmugMug Support Hero Leicester, UKPosts: 1,047Registered Users SmugMug Employee

    Yep, we are looking into this issue.

    SmugMug Support Hero | Customizer | My SmugMug site - http://www.photom.me | Customization Portal - https://portal.photom.me
  • denisegoldbergdenisegoldberg Major grins North Andover, MAPosts: 11,922Super Moderators moderator

    @Richard said:
    Working with SmugHero Tom this morning, we found that the client view of my site also has the wonky behavior in Chrome on OS-X and Win10, but it behaves correctly on my Win7 machine.

    It happens for me in Firefox, Edge, and Chrome, all on Windows 10.

  • Lille UlvenLille Ulven Lille Ulven ScandinaviaPosts: 495Registered Users Major grins

    I checked yesterday on Mac High Sierra with Safari, Firefox, Chrome & Opera.
    I don't believe this is OS or browser related though...but better one more check than missing out on that connection :smile:
    @Richard you are welcome – if I can I will help out :smile:

    http://www.lilleulven.com - The Photos of my travels
    http://blog.lilleulven.com - The Stories of my travels
  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator
    edited April 25, 2018

    Thanks, Lille. I tend to agree that it's not just a browser or OS issue. There seem to be minor differences between Chrome on Win7 and Win10, but it's flawed on both. Thinking about it, it might have something to do with different screen resolutions--my machine is 1920x1080, which is smaller than many newer displays. Dunno.

  • Lille UlvenLille Ulven Lille Ulven ScandinaviaPosts: 495Registered Users Major grins

    I don't think it's depending on screen sizes either, because it is that sm-page-header-div that is not reacting to the data-pinned-region="Header". You will always have that div, no matter what your screen size is, it might only be smaller on smaller screens than on larger ones.
    But I bet @tomnovy and the other SmugMug heroes will soon find a solution :smile:

    http://www.lilleulven.com - The Photos of my travels
    http://blog.lilleulven.com - The Stories of my travels
  • denisegoldbergdenisegoldberg Major grins North Andover, MAPosts: 11,922Super Moderators moderator

    Any chance of getting a status (or a fix!) on this?

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    Bump.

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    @tomnovy said:
    Yep, we are looking into this issue.

    Any progress? It's been a month since I first reported this...

  • RichardRichard Mildly bemused Madrid, SpainPosts: 18,536Administrators, Vanilla Admin moderator

    Looks like it has been fixed. :+1:

  • denisegoldbergdenisegoldberg Major grins North Andover, MAPosts: 11,922Super Moderators moderator

    @Richard said:
    Looks like it has been fixed. :+1:

    Awesome!

Sign In or Register to comment.