critique on critique style

bwg · February 16, 2006

i think critique style is very cool.

however i'm not thrilled with how everything to the left of the exif info is hot (meaning clickable). Just the photo should trigger lightbox, not the entire left 2/3 of the box.

it's just a big pain if i have something like an IM window that opens up on top of the browser window, and i'll click the browser window to get focus back there and lightbox pops up. That's expected behavior if i click on the photo, but not when i click next to the photo.

not a biggie, but just sayin.

edit: this is really only evident with portrait orientated photos

flyingdutchie · February 16, 2006

bigwebguy wrote:

i think critique style is very cool.

however i'm not thrilled with how everything to the left of the exif info is hot (meaning clickable). Just the photo should trigger lightbox, not the entire left 2/3 of the box.

it's just a big pain if i have something like an IM window that opens up on top of the browser window, and i'll click the browser window to get focus back there and lightbox pops up. That's expected behavior if i click on the photo, but not when i click next to the photo.

not a biggie, but just sayin.

edit: this is really only evident with portrait orientated photos

This is what you see on FireFox only, right?
On IE this does not happen for me.
The problem is that there is an <a> element surrounding the <img> element. This <a> element, for some reason extends (invisibly) way beyond the <IMG> element, especially noticable when the image has a vertical (portrait) orientation.

This is how i fixed it:
#critique .photo a {
/* Make the surrounding <a> really hidden */
visibility: hidden;
}
#critique .photo a img {
/* But show the part where the actual image is */
visibility: visible;
}

This fixes the issue on FireFox but it does not mess up IE.